Add Zipkin support of OpenSearch storage (add Docker images) #3766
Conversation
reta
force-pushed
the
issue-3753-docker
branch
4 times, most recently
from
83972b4
to
f5d1ca3
Compare
|
the cve is eureka. I'll help raise a PR https://github.com/openzipkin/zipkin/actions/runs/8761712611?pr=3766 |
Signed-off-by: Andriy Redko <[email protected]>
| export HEALTHCHECK_PATH=/_cluster/health | ||
|
|
||
| # Set tmp folder | ||
| OPENSEARCH_TMPDIR=`java -cp 'classes:lib/*' org.opensearch.tools.launchers.TempDirectory` |
There was a problem hiding this comment.
we are setting this to /tmp as an env variable in dockerfile to /tmp. do you want to always overwrite it like this?
There was a problem hiding this comment.
or does TempDirectory consider an existing OPENSEARCH_TMPDIR.. if so, maybe mention in the comment like below on OPENSEARCH_JAVA_OPTS
There was a problem hiding this comment.
Good question, so TempDirectory uses java.io.tmpdir and pre-creates the opensearch folder there
| export HEALTHCHECK_PATH=/_cluster/health | ||
|
|
||
| # Set tmp folder | ||
| OPENSEARCH_TMPDIR=`java -cp 'classes:lib/*' org.opensearch.tools.launchers.TempDirectory` |
There was a problem hiding this comment.
or does TempDirectory consider an existing OPENSEARCH_TMPDIR.. if so, maybe mention in the comment like below on OPENSEARCH_JAVA_OPTS
Signed-off-by: Andriy Redko <[email protected]>
|
thanks for taking this forward, @reta! |
Add Zipkin support of OpenSearch storage (add Docker images) as dicussed #3765 (comment)